Replace deprecated appdirs with platformdirs#15
Open
agriyakhetarpal wants to merge 2 commits intoemscripten-forge:mainfrom
Open
Replace deprecated appdirs with platformdirs#15agriyakhetarpal wants to merge 2 commits intoemscripten-forge:mainfrom
appdirs with platformdirs#15agriyakhetarpal wants to merge 2 commits intoemscripten-forge:mainfrom
Conversation
agriyakhetarpal
commented
Jan 24, 2025
|
|
||
|
|
||
| def get_appdir(): | ||
| path = Path(appdirs.user_data_dir("pyjs_code_runner", "ThorstenBeier")) |
Author
There was a problem hiding this comment.
I removed ThorstenBeier here (and DerThorsten from conftest.py below), as these strings seemed like a remnant of testing code. The appauthor parameter should be picked up as whatever the default is automatically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See emscripten-forge/empack#113, this needs to be merged for CI to pass there.